Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that knife search returns 10000 rows by default. #3260

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kalroy
Copy link
Collaborator

@kalroy kalroy commented Aug 2, 2024

Description

The knife search by default returns 10k results. If someone needs more than 10k results it needs to pass the number of rows with -R option.

Related Issue

https://chefio.atlassian.net/browse/CHEF-5783

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@kalroy kalroy requested a review from a team as a code owner August 2, 2024 12:46
Copy link

netlify bot commented Aug 2, 2024

Deploy Preview for chef-workstation ready!

Name Link
🔨 Latest commit eea701b
🔍 Latest deploy log https://app.netlify.com/sites/chef-workstation/deploys/66acd5bacf611a0008afd8ec
😎 Deploy Preview https://deploy-preview-3260--chef-workstation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kalroy kalroy force-pushed the kalroy/update_knife_search_doc branch from 453e051 to eea701b Compare August 2, 2024 12:48
Copy link

sonarqubecloud bot commented Aug 2, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant